Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(comp: image): rebuild imageViewer #772

Merged
merged 1 commit into from
Mar 2, 2022
Merged

refactor(comp: image): rebuild imageViewer #772

merged 1 commit into from
Mar 2, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #772 (14ad22a) into main (ac2579a) will increase coverage by 0.73%.
The diff coverage is 90.23%.

❗ Current head 14ad22a differs from pull request most recent head e7aa269. Consider uploading reports for the commit e7aa269 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   83.19%   83.92%   +0.73%     
==========================================
  Files         461      466       +5     
  Lines       12073    12016      -57     
  Branches     2875     2873       -2     
==========================================
+ Hits        10044    10085      +41     
+ Misses       2029     1931      -98
Impacted Files Coverage Δ
...ckages/components/_private/date-panel/src/token.ts 100.00% <ø> (ø)
packages/components/config/src/numFormatter.ts 100.00% <ø> (ø)
packages/components/date-picker/src/token.ts 100.00% <ø> (ø)
packages/components/form/index.ts 100.00% <ø> (ø)
packages/components/form/src/token.ts 100.00% <ø> (+40.00%) ⬆️
packages/components/image/src/types.ts 100.00% <ø> (ø)
packages/components/locales/src/langs/en-US.ts 100.00% <ø> (ø)
packages/components/locales/src/langs/zh-CN.ts 100.00% <ø> (ø)
packages/components/modal/src/token.ts 100.00% <ø> (ø)
packages/components/pagination/src/token.ts 100.00% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2579a...e7aa269. Read the comment docs.

@danranVm danranVm requested a review from typistZxd March 1, 2022 06:10
@danranVm
Copy link
Member

danranVm commented Mar 1, 2022

@typistZxd 有空 review 一下。

@typistZxd
Copy link
Member

@typistZxd 有空 review 一下。

已review，没啥问题

@danranVm danranVm merged commit 3b8c9d9 into IDuxFE:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danranVm danranVm danranVm approved these changes

@typistZxd typistZxd Awaiting requested review from typistZxd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuzaijiang @danranVm @typistZxd